SSO in values wont repercut into configmap

[JDHawken]

Hello guys!
I'm on big upgrade of my ArgoWorkFlows Chart (3.4.8 to 3.5.8), everything looking good or almost, my pods argo-server are on CrashLoopBackOff, when I get the logs, I got the following message :
argo-server-677bb5fb98-ls9rt issuer empty

After long time of check, I notice my ConfigMaps argo-workflow-controller-configmap aren't complety set...

In Production (3.4.8), I got theses seetings :

sso:
  issuer: [my-server]/realms/master
  clientId:
    name: [my-id]
    key: [my-key]
  clientSecret:
    name: [my-secret]
    key: [my-key]
  redirectUrl: [my-server]/oauth2/callback
  rbac:
    enabled: true
  scopes:
    - [my-roles]
nodeEvents:
  enabled: true

But I didn't have theses lines on my test servers...
No problem with my sso, I've even rollback test servers on 3.4.8 and it's worked again!

Here a part on my Helm Charts :
values.yaml

server:
  extraArgs: ["--auth-mode", "sso"]
  sso:
    issuer: ""
    clientId:
      name: argo-server-sso
      key: client-id
    clientSecret:
      name: argo-server-sso
      key: client-secret
    redirectUrl: ""
    rbac:
      enabled: true
  ssoAccounts:
    enabled: true
    prefix: argo
    userRule: "'ARGO_USER' in groups"
    adminRule: "'ARGO_ADMIN' in groups"
  # OJX

values-staging.yaml

server:
  sso:
    issuer: [my-server]/realms/master
    redirectUrl: [my-server]/oauth2/callback

I already checked if my predecessor didn't put any values in /templates/controller but I couldn't find anything.
values.yaml and values-staging.yaml on prod (3.4.8) and staging (3.5.8) are same files, I only updated folders ci and templates and the image.
Any ideas about why Helm just ignore sso part from my values.yaml when I deploy ArgoWorkFlow ?

Many thanks in advance!

[yu-croco]

Hi @JDHawken ,
Though I am not so sure which Chart version (not version of Argo Workflows) you are using, you should check the values.yaml if there are any diffs from your original Chart version?
e.g.) .Values.server.sso.enabled
https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/values.yaml#L695-L698

[JDHawken]

Hey @yu-croco,

Problem solved.... Really?! It's just a line <<.Values.server.sso.enabled>> ? Is this something new ? 😭 .

To explain in more details, I got 3 files :
values.yml : It's a exact copy from the values.yml on github.
values-common.yml : A second yml where I overload some values for production and staging.
If it's specific on staging environment : staging.yml : I overload values.yml a second time with this file.
If it's specific on production environment : production.yml : I overload values.yml a second time with this file.

After your message, I make diff from my latest values.yml (staging) and values.yml I got in production, I didn't find any sso.enabled 3.4.8.
But on 3.5.8 it's cleary specified server.sso.enabled=false 😒.

Now I can continue ! I still have some problem but still investigate on my side for the moment.
Many thanks and have a great weekend !