feat(argo-cd): Add ability to use an external redis instance #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
from
a1cea27 to
0f35adf
Compare
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
4 times, most recently
from
3946400 to
35da4e3
Compare
mkilchhofer
changed the title
mkilchhofer
requested review from
davidkarlsen,
yann-soubeyrand and
mbevc1
as code owners
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
from
35da4e3 to
ca6ee4f
Compare
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
from
c488d68 to
b91c5b4
Compare
This was referenced Mar 18, 2022
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
from
b91c5b4 to
c678b31
Compare
|
Hi @mbevc1 |
|
Hey, sure. I'll give it a look later. Would you mind rebasing please? |
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
force-pushed
the
feature/argocd_externalRedis
branch
from
c678b31 to
d38855c
Compare
|
Cool :) Rebase done |
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
…j#1150) Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1045
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.