feat(argo-cd): Update to use v2.3.1 release

[mikeeq]

That's my first PR to your repository, I will try to follow the checklist and fix all of the issues.

I'm not sure if the chart version should be bumped in minor or major version.

Resolves #1115

---

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

[davidkarlsen]

lgtm

[steinarox]

Is there any config values for notifications or appsets that needs to be added?
like the argocd-notifications-cm https://argo-cd.readthedocs.io/en/latest/operator-manual/notifications/templates/

and appset crd

[davidkarlsen]

Is there any config values for notifications or appsets that needs to be added? like the argocd-notifications-cm argo-cd.readthedocs.io/en/latest/operator-manual/notifications/templates

and appset crd

Awaiting response to this before we let it run and merge.

[mikeeq]

Is there any config values for notifications or appsets that needs to be added? like the argocd-notifications-cm argo-cd.readthedocs.io/en/latest/operator-manual/notifications/templates
and appset crd

Awaiting response to this before we let it run and merge.

Who should respond to that? I'm happy to add everything that's required here, just let me know what exactly ;)

[steinarox]

seems like the appset crd is not in the argoproj manifests. but the kustomize file points here https://raw.githubusercontent.com/argoproj/applicationset/master/manifests/install.yaml

[mikeeq]

ApplicationSet CRD was added ;)

EDIT: I removed status section

...
status:
  acceptedNames:
    kind: ""
    plural: ""
  conditions: []
  storedVersions: []

from appset crd as that section is also removed for extension crd.

[mkilchhofer]

Hmm we need to implement multiple things as we are discussing here: #1115

[pashcan]

Is there any config values for notifications or appsets that needs to be added? like the argocd-notifications-cm argo-cd.readthedocs.io/en/latest/operator-manual/notifications/templates
Who should respond to that? I'm happy to add everything that's required here, just let me know what exactly ;)

The upgrade to v2.3.0 needs to include functionality of that version. Controller deployments, serviceaccounts, roles and rolebindings, default values, etc. Pretty much most of these
https://github.com/argoproj/argo-helm/tree/master/charts/argocd-applicationset/templates
https://github.com/argoproj/argo-helm/tree/master/charts/argocd-notifications/templates

Your commit only includes CRDs but this is a great start!

[mikeeq]

The question is how we want to include those argocd-applicationset and argocd-notifications charts? Add them as dependencies in Chart.yaml or migrate those yaml files over to argo-cd chart?

[mbevc1]

Not sure we had a consensus, but more context is in #1115

[mikeeq]

Guys, were there any official decisions made on how we want to push that forward?

[pashcan]

Seems like consensus is to include applicationsets & notifications charts into the ArgoCD one and cut a new major version.
#1115 (comment)

[mikeeq]

I pushed the latest changes and accordingly to the previous post I migrated applicationset and notification chart templates to the main argo-cd chart. It's an open PR for any comments, just wanted to know if that was a goal and I'm looking forward to any suggestions ;)

I will squash commits when all be done and polished ;)

EDIT. @jasonmacdonald in the linked issue is mentioning that there were some changes in applicationset CRDs, but I couldn't find any (maybe they are not merged yet 🤷).

EDIT2. There are still some changes required in _helpers.tpl and I'm currently working on them.

[steinarox]

@mikeeq i am not sure about deleting the old charts in this PR. This can confuse existing users when the chart and files disappear. The best path imo would be to deprecate the charts and write in their readmes that this is the new chart in a separate PR

[mikeeq]

@steinarox no problem, I will revert them ;)

EDIT. It would be very useful if someone could test applicationset and notifications changes, I deployed it with a default values and they seem to be up and running but I haven't used them before, so maybe someone already has a working configuration and can test it - thanks in advance ;)