feat(argo-cd): Update Notification Liveness/Readiness Probes #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nueavv
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
yu-croco
reviewed
Aug 11, 2024
yu-croco
reviewed
Aug 11, 2024
|
Hi @nueavv , thank you for your PR.
|
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: nueavv <nuguni@kakao.com>
yu-croco
approved these changes
Aug 12, 2024
mkilchhofer
approved these changes
Aug 12, 2024
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Aug 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [argo-cd](https://togithub.com/argoproj/argo-helm) | patch | `7.4.2` -> `7.4.3` | --- ### Release Notes <details> <summary>argoproj/argo-helm (argo-cd)</summary> ### [`v7.4.3`](https://togithub.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.3) [Compare Source](https://togithub.com/argoproj/argo-helm/compare/argo-cd-7.4.2...argo-cd-7.4.3) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. #### What's Changed - feat(argo-cd): Update Notification Liveness/Readiness Probes by [@​nueavv](https://togithub.com/nueavv) in [https://github.com/argoproj/argo-helm/pull/2872](https://togithub.com/argoproj/argo-helm/pull/2872) #### New Contributors - [@​nueavv](https://togithub.com/nueavv) made their first contribution in [https://github.com/argoproj/argo-helm/pull/2872](https://togithub.com/argoproj/argo-helm/pull/2872) **Full Changelog**: argoproj/argo-helm@argo-rollouts-2.37.4...argo-cd-7.4.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Notification controller doesn't have a health checker, I added TCP socket probes.
Resolves #2781
Checklist: