fix: missing lb event (#2021)

* fix: turn missing load balancer log into an event Signed-off-by: zachaller <zachaller@hotmail.com> * consistent naming Signed-off-by: zachaller <zachaller@hotmail.com>
argoproj · May 5, 2022 · 03636ab · 03636ab
1 parent b364782
commit 03636ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/rollout/trafficrouting/alb/alb.go b/rollout/trafficrouting/alb/alb.go
@@ -162,7 +162,7 @@ func (r *Reconciler) VerifyWeight(desiredWeight int32, additionalDestinations ..
 			return pointer.BoolPtr(false), err
 		}
 		if lb == nil || lb.LoadBalancerArn == nil {
-			r.log.Infof("LoadBalancer %s not found", lbIngress.Hostname)
+			r.cfg.Recorder.Warnf(rollout, record.EventOptions{EventReason: conditions.LoadBalancerNotFoundReason}, conditions.LoadBalancerNotFoundMessage, lbIngress.Hostname)
 			return pointer.BoolPtr(false), nil
 		}
 

diff --git a/utils/conditions/conditions.go b/utils/conditions/conditions.go
@@ -157,6 +157,9 @@ const (
 	// WeightVerifyErrorReason is emitted when there is an error verifying the set weight
 	WeightVerifyErrorReason  = "WeightVerifyError"
 	WeightVerifyErrorMessage = "Failed to verify weight: %s"
+	// LoadBalancerNotFoundReason is emitted when load balancer can not be found
+	LoadBalancerNotFoundReason  = "LoadBalancerNotFound"
+	LoadBalancerNotFoundMessage = "Failed to find load balancer: %s"
 )
 
 // NewRolloutCondition creates a new rollout condition.