feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerReplicaSet #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y only) Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Codecov ReportBase: 81.67% // Head: 81.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 81.67% 81.68%
=======================================
Files 126 126
Lines 19124 19132 +8
=======================================
+ Hits 15620 15628 +8
Misses 2710 2710
Partials 794 794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
|
@zachaller |
zachaller
reviewed
Dec 9, 2022
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
ssanders1449
force-pushed
the
issue_1779_MinPodsPerRS
branch
from
d247f32
to
9db92cd
Compare
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
ssanders1449
changed the title
|
Sorry should have caught this in my first look as well. Can we get some docs added to at least the specs page https://argoproj.github.io/argo-rollouts/features/specification/ |
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
|
I want to get this in 1.4 can you please resolve conflicts? |
|
actually nm, i see you enabled maintainers to pushed it was just a codegen issue so I was able to fix it :D |
…_1779_MinPodsPerRS Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
Dec 19, 2022
tperdue321
pushed a commit
to rallyhealth/argo-rollouts
that referenced
this pull request
Jan 12, 2023
….MinPodsPerReplicaSet (argoproj#2448) * add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only) Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix lint and test Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix codegen Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * rename MinPodsPerRS to MinPodsPerReplicaSet Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix lint and codegen Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * update specification.md Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * codegen missed a file Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: Shlomo Sanders <ssanders@synamedia.com> Co-authored-by: zachaller <zachaller@users.noreply.github.com>
tperdue321
pushed a commit
to rallyhealth/argo-rollouts
that referenced
this pull request
Jan 12, 2023
….MinPodsPerReplicaSet (argoproj#2448) * add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only) Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix lint and test Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix codegen Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * rename MinPodsPerRS to MinPodsPerReplicaSet Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * fix lint and codegen Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * update specification.md Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> * codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * codegen missed a file Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Shlomo Sanders <ssanders@synamedia.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: Shlomo Sanders <ssanders@synamedia.com> Co-authored-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #1779
See #1779 for Use Cases
This is option 1 from #1779 (comment)
Signed-off-by: Shlomo Sanders ssanders@synamedia.com