Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Issue #1779: add --canary-min-replicas command-line flag #2410

Closed

Conversation

ssanders1449
Copy link
Contributor

@ssanders1449 ssanders1449 commented Nov 15, 2022

Implements issue #1779
See #1779 for Use Cases

Based on #1779 (comment)

This replaces #1938

@alexef @zachaller

Shlomo Sanders added 3 commits November 15, 2022 11:46
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Go Published Test Results

1 801 tests   1 801 ✔️  2m 30s ⏱️
   102 suites         0 💤
       1 files           0

Results for commit bfb6bac.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 81.55% // Head: 81.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (bfb6bac) compared to base (22ff2c4).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2410      +/-   ##
==========================================
+ Coverage   81.55%   81.56%   +0.01%     
==========================================
  Files         124      124              
  Lines       18931    18968      +37     
==========================================
+ Hits        15439    15472      +33     
- Misses       2702     2706       +4     
  Partials      790      790              
Impacted Files Coverage Δ
utils/defaults/defaults.go 86.87% <0.00%> (-2.23%) ⬇️
utils/replicaset/canary.go 92.80% <100.00%> (+0.08%) ⬆️
rollout/sync.go 80.13% <0.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 36m 47s ⏱️
  92 tests   87 ✔️ 3 💤 2
186 runs  178 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit bfb6bac.

♻️ This comment has been updated with latest results.

Shlomo Sanders added 3 commits November 15, 2022 15:22
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@zachaller
Copy link
Collaborator

closing in favor of #2448

@zachaller zachaller closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants