Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify application dependencies #1706

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

kostis-codefresh
Copy link
Member

Signed-off-by: Kostis Kapelonis kostis@codefresh.io

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1706 (5ec9aac) into master (b3d50d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files         116      116           
  Lines       16075    16075           
=======================================
  Hits        13192    13192           
  Misses       2210     2210           
  Partials      673      673           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d50d1...5ec9aac. Read the comment docs.

Copy link
Member

@huikang huikang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen
Copy link
Member

Thanks!

@jessesuen jessesuen merged commit 6d4174b into argoproj:master Dec 14, 2021
@kostis-codefresh kostis-codefresh deleted the doc-service-deps branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants