Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ci #2373

Closed
wants to merge 5 commits into from
Closed

Test ci #2373

wants to merge 5 commits into from

Conversation

thomas-riccardi
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

The codecov/codecov-action api didn't change with v3.
Node.js version was updated from 12 to 16, fixing deprecation warning.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: Thomas Riccardi <thomas@deepomatic.com>
The actions/upload-artifact api didn't change with v3.
Node.js version was updated from 12 to 16, fixing deprecation warning.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: Thomas Riccardi <thomas@deepomatic.com>
…wnload-artifact

It should be a drop-in replacement: all under path artifacts/, with
sub-directory per artifact name, as before.

Signed-off-by: Thomas Riccardi <thomas@deepomatic.com>
since v2 of EnricoMi/publish-unit-test-result-action:
warning:
Option FILES is deprecated, please use JUNIT_FILES instead!

all files are junit format, and are all named junit.xml

Signed-off-by: Thomas Riccardi <thomas@deepomatic.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Go Published Test Results

1 778 tests   1 778 ✔️  2m 30s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit dfd0b3d.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (dfd0b3d) compared to base (2cf256b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2373   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18536    18536           
=======================================
  Hits        15341    15341           
  Misses       2410     2410           
  Partials      785      785           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

89 tests   86 ✔️  45m 33s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit dfd0b3d.

@thomas-riccardi
Copy link
Contributor Author

I meant to test this on my fork first..

@thomas-riccardi
Copy link
Contributor Author

proper PR is there: #2375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant