docs: provide recommendation for strategies #3531

kostis-codefresh · 2024-04-18T09:04:12Z

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

github-actions · 2024-04-18T09:13:04Z

Go Published Test Results

2 160 tests 2 160 ✅ 2m 53s ⏱️
119 suites 0 💤
1 files 0 ❌

Results for commit a6d14d2.

♻️ This comment has been updated with latest results.

codecov · 2024-04-18T09:13:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (8405f2e) to head (a6d14d2).
Report is 93 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3531      +/-   ##
==========================================
- Coverage   81.83%   78.21%   -3.63%     
==========================================
  Files         135      158      +23     
  Lines       20688    18397    -2291     
==========================================
- Hits        16931    14389    -2542     
- Misses       2883     3101     +218     
- Partials      874      907      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-18T09:37:30Z

E2E Tests Published Test Results

4 files 4 suites 3h 32m 55s ⏱️
110 tests 95 ✅ 6 💤 9 ❌
468 runs 415 ✅ 24 💤 29 ❌

For more details on these failures, see this check.

Results for commit a6d14d2.

♻️ This comment has been updated with latest results.

meeech · 2024-04-18T14:09:13Z

docs/concepts.md

+
+* Blue/Green always works because only one application is active at a time. Not all applications can have different versions running in parallel at the same time (which is what canaries are doing)
+* Blue/Green is simpler because it works WITHOUT a traffic manager. Not all people like service meshes, and not all people have an ingress that is supported by Argo Rollouts


my only issue here is it muddies the fact that progressive canary also has a no traffic manager option. the way its emphasized implies canary doesnt

( i just saw the note at the bottom, but comment still stands)

ok. I will update to make it clear.

thansk. I guess my issue was the big WITHOUT traffic manager, implying its a necessity for canary.

meeech · 2024-04-18T14:13:02Z

docs/concepts.md

+Here is a summary table for the two approaches.
+
+|                           |         Blue/Green         | Canary         |


True. But the big blocker is that Canary needs your application to have 2 instances that are both receiving live traffic at the same time. And not all apps can do this. The traffic manager is important but completely unrelated to that requirement.

Fair. I guess we rank that a bit different (in terms of ease). but i guess there's a big bag of gotchas/tradeoffs, and I get this is meant as an intro guide, so I'll try to avoid getting bogged in details.

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

zachaller · 2024-04-18T15:08:20Z

docs/concepts.md

+Here is a summary table for the two approaches.
+
+|                           |         Blue/Green         | Canary with Traffic manager         |


Do you think we should also call out basic canary, aka canary without traffic router

@zachaller I added a third row to the table to make it clear.

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

sonarqubecloud · 2024-04-18T15:51:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix: switch to retry logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry experiments Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove TODO Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry to setting revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (argoproj#3537) chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (argoproj#3522) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@e1523de...59acb62) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump golangci/golangci-lint-action from 4 to 5 (argoproj#3540) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v4...v5) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs: provide recommendation for strategies (argoproj#3531) * docs: provide recommendation for strategies Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: traffic manager clarifications Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: explain canary with/out traffic manager Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: add 3 columns on the comparison table Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> --------- Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> feat(dashboard): change the color of the current rollout step (argoproj#3526) I feel that having the current (running) step in a orange color is misleading, as orange usually means warning. This commit changes the color to the `$argo-running-color`. Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co> chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.37.0 to 1.38.0 (argoproj#3525) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.0...service/s3/v1.38.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> perform all of set revision actions on retry Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix variable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clean logs, always dump controller e2e logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lower timeout Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump timeout on e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry on rollout conflict Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't reque on rs changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> reque rs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump qps for e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix gen-crd Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> move log lines Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix one e2e test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1 (argoproj#3552) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (argoproj#3550) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (argoproj#3548) Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test for updating rs revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry for ephemeral metadata Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clear some fields Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> refactor into function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to patch fallback Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch ephemeral metadata sync to shared function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch merge type Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't update status Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to not use patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to small patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> some cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove not found rollout removal Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> working setup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> small cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix: fallback to patch on scale conflict Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix: switch to retry logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry experiments Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove TODO Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry to setting revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (#3537) chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (#3522) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@e1523de...59acb62) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump golangci/golangci-lint-action from 4 to 5 (#3540) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v4...v5) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs: provide recommendation for strategies (#3531) * docs: provide recommendation for strategies Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: traffic manager clarifications Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: explain canary with/out traffic manager Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: add 3 columns on the comparison table Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> --------- Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> feat(dashboard): change the color of the current rollout step (#3526) I feel that having the current (running) step in a orange color is misleading, as orange usually means warning. This commit changes the color to the `$argo-running-color`. Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co> chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.37.0 to 1.38.0 (#3525) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.0...service/s3/v1.38.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> perform all of set revision actions on retry Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix variable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clean logs, always dump controller e2e logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lower timeout Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump timeout on e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry on rollout conflict Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't reque on rs changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> reque rs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump qps for e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix gen-crd Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> move log lines Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix one e2e test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1 (#3552) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (#3550) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (#3548) Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test for updating rs revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry for ephemeral metadata Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clear some fields Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> refactor into function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to patch fallback Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch ephemeral metadata sync to shared function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch merge type Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't update status Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to not use patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to small patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> some cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove not found rollout removal Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> working setup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> small cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * typo Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup commented out code Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * only patch rollouts manged fields Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * reduce patch size Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * get some logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * improve tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add env var to log diff Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove expirment rs patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * imporve logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * use correct variable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change env var Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove not found rollouts Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * update replica count Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * refactor cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * keep track of UpdatedReplicas on sync Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * some hpa tests and log changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove update to UpdatedReplicas Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add more test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * undo change Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add comment to flaky tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup Makefile Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * use labels Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove make file change Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add label to test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * review changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change to TODO Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add extra logging for tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add ignore to codecov Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * we always generate patch because we are comparing against emtpy obj Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* docs: provide recommendation for strategies Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: traffic manager clarifications Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: explain canary with/out traffic manager Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: add 3 columns on the comparison table Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> --------- Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* fix: fallback to patch on scale conflict Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix: switch to retry logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry experiments Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove TODO Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove accidental add Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry to setting revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (argoproj#3537) chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (argoproj#3522) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@e1523de...59acb62) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump golangci/golangci-lint-action from 4 to 5 (argoproj#3540) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v4...v5) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs: provide recommendation for strategies (argoproj#3531) * docs: provide recommendation for strategies Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: traffic manager clarifications Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: explain canary with/out traffic manager Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: add 3 columns on the comparison table Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> --------- Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> feat(dashboard): change the color of the current rollout step (argoproj#3526) I feel that having the current (running) step in a orange color is misleading, as orange usually means warning. This commit changes the color to the `$argo-running-color`. Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co> chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.37.0 to 1.38.0 (argoproj#3525) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.0...service/s3/v1.38.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> perform all of set revision actions on retry Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix variable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry counts to logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clean logs, always dump controller e2e logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lower timeout Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump timeout on e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> retry on rollout conflict Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't reque on rs changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> reque rs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> bump qps for e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix gen-crd Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> move log lines Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix one e2e test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1 (argoproj#3552) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (argoproj#3550) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (argoproj#3548) Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add test for updating rs revision Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add retry for ephemeral metadata Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> clear some fields Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> add logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> refactor into function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to patch fallback Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch ephemeral metadata sync to shared function Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> siwtch merge type Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> don't update status Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch rollout update to not use patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> change log Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> switch to small patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> some cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> remove not found rollout removal Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> working setup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> small cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * typo Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup commented out code Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * only patch rollouts manged fields Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * reduce patch size Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * get some logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * improve tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add env var to log diff Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove expirment rs patch Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * imporve logs Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * use correct variable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change env var Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix flaky e2e Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove not found rollouts Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * update replica count Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * lint Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * refactor cleanup Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * keep track of UpdatedReplicas on sync Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * some hpa tests and log changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove update to UpdatedReplicas Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add more test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * undo change Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add comment to flaky tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup Makefile Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * use labels Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * remove make file change Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add label to test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * review changes Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change to TODO Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add extra logging for tests Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * Trigger Build Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add ignore to codecov Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * we always generate patch because we are comparing against emtpy obj Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

docs: provide recommendation for strategies

fc3bdbe

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

meeech reviewed Apr 18, 2024

View reviewed changes

docs: traffic manager clarifications

36a2c1a

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

kostis-codefresh requested a review from zachaller April 18, 2024 14:56

zachaller reviewed Apr 18, 2024

View reviewed changes

kostis-codefresh added 2 commits April 18, 2024 15:49

docs: explain canary with/out traffic manager

9ca44e7

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

docs: add 3 columns on the comparison table

a6d14d2

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

zachaller approved these changes Apr 29, 2024

View reviewed changes

zachaller merged commit 63fd6e3 into argoproj:master Apr 29, 2024
19 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: provide recommendation for strategies #3531

docs: provide recommendation for strategies #3531

kostis-codefresh commented Apr 18, 2024

github-actions bot commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Apr 18, 2024 •

edited

Loading

meeech Apr 18, 2024 •

edited

Loading

meeech Apr 18, 2024

kostis-codefresh Apr 18, 2024

kostis-codefresh Apr 18, 2024

meeech Apr 19, 2024

meeech Apr 18, 2024 •

edited

Loading

kostis-codefresh Apr 18, 2024

meeech Apr 19, 2024

zachaller Apr 18, 2024

kostis-codefresh Apr 18, 2024

sonarqubecloud bot commented Apr 18, 2024


		* Blue/Green always works because only one application is active at a time. Not all applications can have different versions running in parallel at the same time (which is what canaries are doing)
		* Blue/Green is simpler because it works WITHOUT a traffic manager. Not all people like service meshes, and not all people have an ingress that is supported by Argo Rollouts

		Here is a summary table for the two approaches.

		\| \| Blue/Green \| Canary \|

	\| \| Blue/Green \| Canary \|
	\| \| Blue/Green \| Canary w/Service Mesh \|

		Here is a summary table for the two approaches.

		\| \| Blue/Green \| Canary with Traffic manager \|

docs: provide recommendation for strategies #3531

docs: provide recommendation for strategies #3531

Conversation

kostis-codefresh commented Apr 18, 2024

github-actions bot commented Apr 18, 2024 • edited Loading

Go Published Test Results

codecov bot commented Apr 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 18, 2024 • edited Loading

E2E Tests Published Test Results

meeech Apr 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meeech Apr 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 18, 2024

Quality Gate passed

github-actions bot commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Apr 18, 2024 •

edited

Loading

meeech Apr 18, 2024 •

edited

Loading

meeech Apr 18, 2024 •

edited

Loading