fix(metricprovider): reuse http.Transport for http.Client #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive. Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use. Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
|
Published E2E Test Results 4 files 4 suites 3h 24m 50s ⏱️ For more details on these failures, see this check. Results for commit 8373787. |
Published Unit Test Results2 257 tests 2 257 ✅ 2m 58s ⏱️ Results for commit 8373787. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3780 +/- ##
==========================================
+ Coverage 83.97% 83.98% +0.01%
==========================================
Files 161 161
Lines 18492 18495 +3
==========================================
+ Hits 15528 15533 +5
+ Misses 2100 2099 -1
+ Partials 864 863 -1 ☔ View full report in Codecov by Sentry. |
zachaller
approved these changes
Aug 12, 2024
zachaller
pushed a commit
that referenced
this pull request
Aug 13, 2024
The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive. Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use. Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
meeech
pushed a commit
to CircleCI-Public/argo-rollouts
that referenced
this pull request
Feb 10, 2025
) The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive. Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use. Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive.
Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".