fix: Change scope node to taskNode at executeTmplLifeCycleHook

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
argoproj · Aug 26, 2023 · 11c2144 · 11c2144
1 parent bc6b77c
commit 11c2144
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/workflow/controller/dag.go b/workflow/controller/dag.go
@@ -277,7 +277,7 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 				woc.markNodeError(node.Name, err)
 				return node, err
 			}
-			scope.addParamToScope(fmt.Sprintf("tasks.%s.status", task.Name), string(node.Phase))
+			scope.addParamToScope(fmt.Sprintf("tasks.%s.status", task.Name), string(taskNode.Phase))
 			_, err = woc.executeTmplLifeCycleHook(ctx, scope, dagCtx.GetTask(taskName).Hooks, taskNode, dagCtx.boundaryID, dagCtx.tmplCtx, "tasks."+taskName)
 			if err != nil {
 				woc.markNodeError(node.Name, err)
@@ -405,7 +405,6 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex
 
 	node := dagCtx.getTaskNode(taskName)
 	task := dagCtx.GetTask(taskName)
-	log := woc.log.WithField("taskName", taskName)
 	if node != nil && (node.Fulfilled() || node.Phase == wfv1.NodeRunning) {
 		scope, err := woc.buildLocalScopeFromTask(dagCtx, task)
 		if err != nil {