Reuse IsTransientError

Signed-off-by: Seokju Hong <seokju@vessl.ai>
argoproj · Sep 26, 2022 · 40f28e4 · 40f28e4
1 parent 988fa41
commit 40f28e4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/util/errors/errors.go b/util/errors/errors.go
@@ -38,13 +38,6 @@ func IsTransientErr(err error) bool {
 	return isTransient
 }
 
-func IsTransientNetworkErr(err error) bool {
-	if err == nil {
-		return false
-	}
-	return isTransientNetworkErr(err)
-}
-
 func matchTransientErrPattern(err error) bool {
 	// TRANSIENT_ERROR_PATTERN allows to specify the pattern to match for errors that can be seen as transient
 	// and retryable.

diff --git a/workflow/util/plugins/plugin.go b/workflow/util/plugins/plugin.go
@@ -54,7 +54,7 @@ func (p *Client) Call(ctx context.Context, method string, args interface{}, repl
 				return true
 			}
 		}
-		return strings.Contains(err.Error(), "connection refused") || errors.IsTransientNetworkErr(err)
+		return strings.Contains(err.Error(), "connection refused") || errors.IsTransientErr(err)
 	}, func() error {
 		log.Debug("Calling plugin")
 		req, err := http.NewRequestWithContext(ctx, "POST", fmt.Sprintf("%s/api/v1/%s", p.address, method), bytes.NewBuffer(body))