Skip to content

Commit

Permalink
Fix string format arguments in workflow utilities. (#1070)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmcarp authored and jessesuen committed Nov 3, 2018
1 parent 76b14f5 commit 79b3e30
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions workflow/util/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ func FormulateResubmitWorkflow(wf *wfv1.Workflow, memoized bool) (*wfv1.Workflow
// NOTE: NodeRunning shouldn't really happen except in weird scenarios where controller
// mismanages state (e.g. panic when operating on a workflow)
default:
return nil, errors.InternalErrorf("Workflow cannot be resubmitted with nodes in %s phase", node, node.Phase)
return nil, errors.InternalErrorf("Workflow cannot be resubmitted with node %s in %s phase", node, node.Phase)
}
}
return &newWF, nil
Expand Down Expand Up @@ -460,7 +460,7 @@ func RetryWorkflow(kubeClient kubernetes.Interface, wfClient v1alpha1.WorkflowIn
// do not add this status to the node. pretend as if this node never existed.
default:
// Do not allow retry of workflows with pods in Running/Pending phase
return nil, errors.InternalErrorf("Workflow cannot be retried with nodes in %s phase", node, node.Phase)
return nil, errors.InternalErrorf("Workflow cannot be retried with node %s in %s phase", node, node.Phase)
}
if node.Type == wfv1.NodeTypePod {
log.Infof("Deleting pod: %s", node.ID)
Expand Down

0 comments on commit 79b3e30

Please sign in to comment.