fix(ui): various ui fixes (#5606)

Signed-off-by: Iven Hsu <ivenvd@gmail.com>
argoproj · Apr 8, 2021 · 9d175cf · 9d175cf
1 parent b4ce78b
commit 9d175cf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/ui/src/app/shared/components/graph/graph-panel.scss b/ui/src/app/shared/components/graph/graph-panel.scss
@@ -51,7 +51,6 @@
 }
 
 .graph {
- overflow: scroll;
  text-align: center;
  max-height: calc(100vh - 2 * #{$top-bar-height});
 

diff --git a/ui/src/app/workflows/components/workflow-details/workflow-details.scss b/ui/src/app/workflows/components/workflow-details/workflow-details.scss
@@ -43,6 +43,7 @@
  width: 100%;
  transition: width 0.2s;
  float: left;
+ overflow: auto;
 
  .workflow-dag {
  margin: 0;

diff --git a/ui/src/app/workflows/components/workflow-drawer/workflow-drawer.scss b/ui/src/app/workflows/components/workflow-drawer/workflow-drawer.scss
@@ -1,7 +1,6 @@
 @import 'node_modules/argo-ui/src/styles/config';
 
 .workflow-drawer {
- height: 100%;
  font-size: 13px;
  background-color: $argo-color-gray-1;
  padding: 1.5em 15px;

diff --git a/ui/src/app/workflows/components/workflows-row/workflows-row.tsx b/ui/src/app/workflows/components/workflows-row/workflows-row.tsx
@@ -1,5 +1,6 @@
 import {Ticker} from 'argo-ui/src/index';
 import * as React from 'react';
+import {Link} from 'react-router-dom';
 import {Workflow} from '../../../../models';
 import {uiUrl} from '../../../shared/base';
 import {DurationPanel} from '../../../shared/components/duration-panel';
@@ -46,10 +47,7 @@ export class WorkflowsRow extends React.Component<WorkflowsRowProps, WorkflowRow
  />
  <PhaseIcon value={wf.status.phase} />
  </div>
- <a
- href={uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`)}
- className='small-11 row'
- ref={el => el && el.style.setProperty('max-width', '91.6666666667%', 'important')}>
+ <Link to={uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`)} className='small-11 row'>
  <div className='columns small-2'>{wf.metadata.name}</div>
  <div className='columns small-2'>{wf.metadata.namespace}</div>
  <div className='columns small-1'>
@@ -94,7 +92,7 @@ export class WorkflowsRow extends React.Component<WorkflowsRowProps, WorkflowRow
  }}
  />
  )}
- </a>
+ </Link>
  </div>
  </div>
  );