Skip to content

Commit

Permalink
chore: Remove deprecated metrics service from manifests (#9399)
Browse files Browse the repository at this point in the history
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
  • Loading branch information
terrytangyuan authored Aug 23, 2022
1 parent 675d86f commit bbddfc3
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 80 deletions.
1 change: 0 additions & 1 deletion manifests/base/workflow-controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ resources:
- workflow-controller-configmap.yaml
- workflow-controller-deployment.yaml
- workflow-controller-sa.yaml
- workflow-controller-metrics-service.yaml
- workflow-controller-priorityclass.yaml

This file was deleted.

20 changes: 0 additions & 20 deletions manifests/quick-start-minimal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1611,26 +1611,6 @@ spec:
selector:
app: minio
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down
20 changes: 0 additions & 20 deletions manifests/quick-start-mysql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1655,26 +1655,6 @@ spec:
selector:
app: mysql
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down
20 changes: 0 additions & 20 deletions manifests/quick-start-postgres.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1655,26 +1655,6 @@ spec:
selector:
app: postgres
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down

0 comments on commit bbddfc3

Please sign in to comment.