fix: ensure labels is defined before key access. Fixes #11602 (#11638)

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
argoproj · Aug 28, 2023 · d99efa7 · d99efa7
1 parent 0cffdff
commit d99efa7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ui/src/app/workflows/components/workflows-row/workflows-row.tsx b/ui/src/app/workflows/components/workflows-row/workflows-row.tsx
@@ -94,7 +94,8 @@ export class WorkflowsRow extends React.Component<WorkflowsRowProps, WorkflowRow
                         </div>
                         <div className='columns small-1'>{isArchivedWorkflow(wf) ? 'true' : 'false'}</div>
                         {(this.props.columns || []).map(column => {
-                            const value = wf.metadata?.labels[column.key];
+                            // best not to make any assumptions and wait until this data is filled
+                            const value = wf?.metadata?.labels?.[column.key] ?? 'unknown';
                             return (
                                 <div key={column.name} className='columns small-1'>
                                     {value}