Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive UI broken since v3.4.5 #10606

Closed
3 tasks done
nakamorichi opened this issue Feb 28, 2023 · 3 comments · Fixed by #10622
Closed
3 tasks done

Archive UI broken since v3.4.5 #10606

nakamorichi opened this issue Feb 28, 2023 · 3 comments · Fixed by #10622
Assignees
@nakamorichi
Labels
area/ui area/workflow-archive P1 High priority. All bugs with >=5 thumbs up that aren’t P0, plus: Any other bugs deemed high priority type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@nakamorichi
Copy link
Contributor

nakamorichi commented Feb 28, 2023 •
edited
Loading

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Screenshot 2023-02-24 at 12 57 32

Screenshot 2023-02-24 at 12 57 55

Screenshot 2023-02-24 at 12 58 22

NOTE: v3.4.4 does not have the issue

Version

v3.4.5, master (786639d)

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

not related to particular workflow, but Archived Workflows UI component. Apparently regression after v3.4.4.

Logs from the workflow controller

No errors

Logs from in your workflow's wait container

N/A (not related to workflow execution)
@caelan-io caelan-io added the type/regression Regression from previous behavior (a specific type of bug) label Mar 1, 2023
@juliev0 juliev0 self-assigned this Mar 1, 2023
@juliev0
Copy link
Contributor

juliev0 commented Mar 1, 2023

I think I broke this here so I will take this.

@nakamorichi
Copy link
Contributor Author

@juliev0 I have fix already, submitting PR in a moment.

@juliev0
Copy link
Contributor

juliev0 commented Mar 2, 2023

@juliev0 I have fix already, submitting PR in a moment.

Great! Thank you!

@juliev0 juliev0 assigned nakamorichi and unassigned juliev0 Mar 2, 2023
nakamorichi added a commit to nakamorichi/argo-workflows that referenced this issue Mar 2, 2023
@nakamorichi
fix: Archive UI broken since v3.4.5 (argoproj#10606)
ebceb02 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
@nakamorichi nakamorichi mentioned this issue Mar 2, 2023
Merged
nakamorichi added a commit to nakamorichi/argo-workflows that referenced this issue Mar 2, 2023
@nakamorichi
fix: Archive UI broken since v3.4.5 (argoproj#10606)
e838002 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
nakamorichi added a commit to nakamorichi/argo-workflows that referenced this issue Mar 2, 2023
@nakamorichi
fix: Archive UI broken since v3.4.5 (argoproj#10606)
50ece28 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
alexec pushed a commit that referenced this issue Mar 5, 2023
@nakamorichi
fix: Fix broken archive UI Fixes #10606 (#10622)
d536eec 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
alexec pushed a commit that referenced this issue Mar 5, 2023
@nakamorichi @alexec
fix: Fix broken archive UI Fixes #10606 (#10622)
f151657 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
@terrytangyuan terrytangyuan mentioned this issue Mar 24, 2023
Closed
33 tasks
terrytangyuan pushed a commit that referenced this issue Mar 29, 2023
@nakamorichi @terrytangyuan
fix: Fix broken archive UI Fixes #10606 (#10622)
ac84d00 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this issue Jul 4, 2023
@nakamorichi @JPZ13
fix: Fix broken archive UI Fixes argoproj#10606 (argoproj#10622)
b8da934 
Signed-off-by: Petri Kivikangas <36138+Kitanotori@users.noreply.github.com>
@agilgur5 agilgur5 added area/ui area/workflow-archive P1 High priority. All bugs with >=5 thumbs up that aren’t P0, plus: Any other bugs deemed high priority labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nakamorichi nakamorichi

Labels
area/ui area/workflow-archive P1 High priority. All bugs with >=5 thumbs up that aren’t P0, plus: Any other bugs deemed high priority type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix broken archive UI Fixes #10606 nakamorichi/argo-workflows
4 participants
@nakamorichi @agilgur5 @juliev0 @caelan-io