Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo CLI requests have inaccurate user agent #11996

Closed
3 tasks done
terrytangyuan opened this issue Oct 14, 2023 · 0 comments · Fixed by #12276
Closed
3 tasks done

Argo CLI requests have inaccurate user agent #11996

terrytangyuan opened this issue Oct 14, 2023 · 0 comments · Fixed by #12276
Assignees
Labels
area/cli The `argo` CLI P3 Low priority type/bug

Comments

@terrytangyuan
Copy link
Member

terrytangyuan commented Oct 14, 2023

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Currently, requests through Argo CLI have the user agent argo/v0.0.0. It should be more distinguishable like argo-cli/v3.4.5. These were missed when I initially added the user agents in #5624 and #5014.

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Not necessary

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli The `argo` CLI P3 Low priority type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants