Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHTTPArtifactDriver_Load intermittently fails on the windows CI suite #12744

Closed
3 of 4 tasks
blkperl opened this issue Mar 5, 2024 · 3 comments · Fixed by #13670
Closed
3 of 4 tasks

TestHTTPArtifactDriver_Load intermittently fails on the windows CI suite #12744

blkperl opened this issue Mar 5, 2024 · 3 comments · Fixed by #13670
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/build Build or GithubAction/CI issues area/windows Windows Container support P3 Low priority type/bug type/tech-debt

Comments

@blkperl
Copy link
Contributor

blkperl commented Mar 5, 2024 •
edited
Loading

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

--- FAIL: TestHTTPArtifactDriver_Load (0.00s)
    --- FAIL: TestHTTPArtifactDriver_Load/Found (0.00s)
        http_test.go:26: 
            	Error Trace:	D:/a/argo-workflows/argo-workflows/workflow/artifacts/http/http_test.go:26
            	Error:      	Received unexpected error:
            	            	open /tmp/found: The system cannot find the path specified.
            	Test:       	TestHTTPArtifactDriver_Load/Found

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

n/a

Logs from in your workflow's wait container

n/a
@agilgur5 agilgur5 added area/templates/http P3 Low priority area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix area/build Build or GithubAction/CI issues and removed area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels Mar 8, 2024
@blkperl
Copy link
Contributor Author

blkperl commented Mar 27, 2024

Another failure: https://github.com/argoproj/argo-workflows/actions/runs/8444739966/job/23130832000?pr=12847

@agilgur5
Copy link
Member

agilgur5 commented Apr 8, 2024

cc @mweibel who added the Windows unit tests in #12011. Also for reference, the unfinished #12071

@mweibel
Copy link
Contributor

mweibel commented Apr 9, 2024

ah yeah, sorry about that - I didn't get to working on that in a while. I hope I can find some time soon for it. Will then also take a look at this failure.

@agilgur5 agilgur5 added the area/windows Windows Container support label Jun 6, 2024
MasonM added a commit to MasonM/argo-workflows that referenced this issue Sep 27, 2024
@MasonM
ci: follow-up changes and fix flaky Windows tests. Fixes argoproj#12744
e2ef526 
This addresses the comments from
argoproj#13660. Also, it
hopefully fixes the flaky `CI / Windows Unit Tests (pull_request)` test
suite. The errors indicate it's trying to write temp files to `/tmp`:
```
    --- FAIL: TestArtifactoryArtifactDriver_Load/Found (0.00s)
        http_test.go:75:
            	Error Trace:	D:/a/argo-workflows/argo-workflows/workflow/artifacts/http/http_test.go:75
            	Error:      	Received unexpected error:
            	            	open /tmp/found: The system cannot find the path specified.
            	Test:       	TestArtifactoryArtifactDriver_Load/Found
```

which obviously isn't the right directory under Windows, but the test
does pass sometimes, and it seems like writing to the wrong directory
would cause consistent failures. Regardless, the tests should be using
`os.CreateTemp()` for this anyway.

Signed-off-by: Mason Malone <mmalone@adobe.com>
MasonM added a commit to MasonM/argo-workflows that referenced this issue Sep 27, 2024
@MasonM
ci: follow-up changes and fix flaky Windows tests. Fixes argoproj#12744
b7047cd 
This addresses the comments from
argoproj#13660. Also, it
hopefully fixes the flaky `CI / Windows Unit Tests (pull_request)` test
suite. The errors indicate it's trying to write temp files to `/tmp`:
```
    --- FAIL: TestArtifactoryArtifactDriver_Load/Found (0.00s)
        http_test.go:75:
            	Error Trace:	D:/a/argo-workflows/argo-workflows/workflow/artifacts/http/http_test.go:75
            	Error:      	Received unexpected error:
            	            	open /tmp/found: The system cannot find the path specified.
            	Test:       	TestArtifactoryArtifactDriver_Load/Found
```

which obviously isn't the right directory under Windows, but the test
does pass sometimes, and it seems like writing to the wrong directory
would cause consistent failures. Regardless, the tests should be using
`os.CreateTemp()` for this anyway.

Signed-off-by: Mason Malone <mmalone@adobe.com>
@MasonM MasonM mentioned this issue Sep 27, 2024
Merged
MasonM added a commit to MasonM/argo-workflows that referenced this issue Sep 27, 2024
@MasonM
ci: follow-up changes and fix flaky Windows tests. Fixes argoproj#12744
edd1d00 
This addresses the comments from
argoproj#13660. Also, it
hopefully fixes the flaky `CI / Windows Unit Tests (pull_request)` test
suite. The errors indicate it's trying to write temp files to `/tmp`:
```
    --- FAIL: TestArtifactoryArtifactDriver_Load/Found (0.00s)
        http_test.go:75:
            	Error Trace:	D:/a/argo-workflows/argo-workflows/workflow/artifacts/http/http_test.go:75
            	Error:      	Received unexpected error:
            	            	open /tmp/found: The system cannot find the path specified.
            	Test:       	TestArtifactoryArtifactDriver_Load/Found
```

which obviously isn't the right directory under Windows, but the test
does pass sometimes, and it seems like writing to the wrong directory
would cause consistent failures. Regardless, the tests should be using
`os.CreateTemp()` for this anyway.

Signed-off-by: Mason Malone <mmalone@adobe.com>
Joibel pushed a commit that referenced this issue Sep 27, 2024
@MasonM
ci: follow-up changes and fix flaky Windows tests. Fixes #12744 (#13670)
7f14810 
Signed-off-by: Mason Malone <mmalone@adobe.com>
@agilgur5 agilgur5 changed the title TestHTTPArtifactDriver_Load intermittently fails on the windows CI suite TestHTTPArtifactDriver_Load intermittently fails on the windows CI suite Sep 27, 2024
@agilgur5 agilgur5 added area/artifacts S3/GCP/OSS/Git/HDFS etc and removed area/templates/http labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/build Build or GithubAction/CI issues area/windows Windows Container support P3 Low priority type/bug type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: follow-ups + fix flaky Windows http artifact tests. Fixes #12744 MasonM/argo-workflows
3 participants
@blkperl @mweibel @agilgur5