Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct timezone in logs #3474

Closed
hadim opened this issue Jul 14, 2020 · 8 comments · Fixed by #10120
Closed

Correct timezone in logs #3474

hadim opened this issue Jul 14, 2020 · 8 comments · Fixed by #10120
Assignees
@isubasinghe
Labels
area/ui good first issue Good for newcomers hacktoberfest solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request

Comments

@hadim
Copy link

hadim commented Jul 14, 2020

The logs provided by the UI are timestamped. The dates and times provided are always the European ones.

I tried to set TZ=America/Toronto to both the workflow-controller and argo-server deployment without success.

Is that possible to configure the timezone?
@hadim hadim added the type/bug label Jul 14, 2020
@alexec alexec added type/feature Feature request and removed type/bug labels Jul 14, 2020
@alexec
Copy link
Contributor

alexec commented Jul 14, 2020

The timestamps in the logs are standard GMT (was UTC) timestamps. It is not currently configurable, but I think it would be easy to contribute a change to enable this. Would you be intested?

@hadim
Copy link
Author

hadim commented Jul 14, 2020

I am new to golang but happy to help if you point me in the right direction.

@hadim
Copy link
Author

hadim commented Jul 14, 2020

I guess it's simple to do that on the UI side. But would be better to have this option on the server-side right?

@alexec
Copy link
Contributor

alexec commented Jul 14, 2020

I would implement this on the UI side, as it is a display issue.

Looking at the code:

https://github.com/argoproj/argo/blob/master/ui/src/app/workflows/components/workflow-logs-viewer/full-height-logs-viewer.tsx#L18

That is where to make the fix.

@alexec alexec added area/ui and removed help wanted labels Feb 7, 2022
@caelan-io caelan-io added good first issue Good for newcomers hacktoberfest solution/suggested A solution to the bug has been suggested. Someone needs to implement it. labels Nov 1, 2022
@DhwanishShah
Copy link

DhwanishShah commented Nov 14, 2022 •
edited
Loading

Hi, I want to contribute in this. Can you assign me for this issue? Can you assign me a mentor as i am new to this community? @caelan-io @alexec @hadim

@caelan-io
Copy link
Member

Great to hear. Please feel free to get started and open a pr once ready for review. I can support you on this @DhwanishShah

@isubasinghe isubasinghe self-assigned this Nov 25, 2022
@isubasinghe isubasinghe mentioned this issue Nov 27, 2022
Merged
7 tasks
sarabala1979 pushed a commit that referenced this issue Jan 31, 2023
@isubasinghe
feat: allow switching timezone for date rendering. Fixes #3474 (#10120)
8e7c734 
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
reddymh pushed a commit to reddymh/argo-workflows that referenced this issue Jan 31, 2023
@isubasinghe @reddymh
feat: allow switching timezone for date rendering. Fixes argoproj#3474 (
84058c2 
argoproj#10120)

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Rajshekar Reddy <reddymh@gmail.com>
@yay14
Copy link

yay14 commented Mar 15, 2023

@sarabala1979 @caelan-io is this issue solved? can i see logs in my local timezone now? can you also point to what changes are required?

@caelan-io
Copy link
Member

@yay14 - please see this comment on the PR: #10120 (comment)

@terrytangyuan terrytangyuan mentioned this issue Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isubasinghe isubasinghe

Labels
area/ui good first issue Good for newcomers hacktoberfest solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow switching timezone for date rendering. Fixes #3474 isubasinghe/argo-workflows
6 participants
@hadim @alexec @isubasinghe @yay14 @caelan-io @DhwanishShah