Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techdebt: Introduced wfv1.WorkflowPhase #4824

Closed
alexec opened this issue Jan 4, 2021 · 2 comments · Fixed by #4856
Closed

techdebt: Introduced wfv1.WorkflowPhase #4824

alexec opened this issue Jan 4, 2021 · 2 comments · Fixed by #4856

Comments

@alexec
Copy link
Contributor

alexec commented Jan 4, 2021

We use NodePhase for this, but it NodePhase has several values which do not apply to workflows.
@alexec alexec added type/feature Feature request epic/tech-debt and removed type/feature Feature request labels Jan 4, 2021
@simster7 simster7 mentioned this issue Jan 5, 2021
Merged
1 task
@alexec alexec linked a pull request Jan 11, 2021 that will close this issue
chore: Introduce WorkflowPhase #4856
Merged
1 task
@alexec
Copy link
Contributor Author

alexec commented Jan 14, 2021

I’m wrong about workflow status - it can be any status the entry point is which includes skipped and omitted. While this is obviously going to be very rare, I don't think there is great benefit in fixing this.

@alexec alexec closed this as completed Jan 14, 2021
@alexec alexec reopened this Jan 14, 2021
@alexec
Copy link
Contributor Author

alexec commented Jan 14, 2021

@jessesuen should we actually be preventing workflows from taking Omitted and Skipped phases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Introduce WorkflowPhase alexec/argo-workflows
1 participant
@alexec