chore: Introduce WorkflowPhase
#4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
reviewed
Jan 12, 2021
| WorkflowError WorkflowPhase = "Error" | ||
| ) | ||
|
|
||
| func (p WorkflowPhase) Completed() bool { |
There was a problem hiding this comment.
I'm not sure either fulfilled or complete should apply to the workflows phase at all. The source of truth is the label. Phase and conditions are just copies of this information.
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
approved these changes
Jan 20, 2021
|
|
||
| export const WorkflowPhases: NodePhase[] = ['Pending', 'Running', 'Succeeded', 'Failed', 'Error']; | ||
| export type NodePhase = '' | 'Pending' | 'Running' | 'Succeeded' | 'Skipped' | 'Failed' | 'Error' | 'Omitted'; |
Comment on lines
+363
to
+371
| workflowStatus := map[wfv1.NodePhase]wfv1.WorkflowPhase{ | ||
| wfv1.NodePending: wfv1.WorkflowPending, | ||
| wfv1.NodeRunning: wfv1.WorkflowRunning, | ||
| wfv1.NodeSucceeded: wfv1.WorkflowSucceeded, | ||
| wfv1.NodeSkipped: wfv1.WorkflowSucceeded, | ||
| wfv1.NodeFailed: wfv1.WorkflowFailed, | ||
| wfv1.NodeError: wfv1.WorkflowError, | ||
| wfv1.NodeOmitted: wfv1.WorkflowSucceeded, | ||
| }[node.Phase] |
There was a problem hiding this comment.
Perhaps extract this to a function? Could potentially be useful elsewhere
There was a problem hiding this comment.
I will do that - I can add a test then
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: