Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to argo v3 #367

Merged
merged 12 commits into from
Mar 7, 2022
Merged

Update to argo v3 #367

merged 12 commits into from
Mar 7, 2022

Conversation

dguendisch
Copy link
Member

How to categorize this PR?

/area enhancement

What this PR does / why we need it:
Updates argo to v3. This includes one API incompatibility (argoproj/argo-workflows#4856) where argo introduced a dedicated WorkflowPhase to accomodate for the fact that not all NodePhases are applicable to workflows.
In the same spirit I added now different types for Testrun Phases and Teststep Phases.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 25, 2021
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels Aug 25, 2021
@gardener-robot
Copy link

@dguendisch Label area/enhancement does not exist.

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 25, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Aug 25, 2021
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@gardener-robot
Copy link

@gardener-ci-robot Command /add is not available to you but only to a Maintainer, Member, Author.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2022
@hendrikKahl
Copy link
Contributor

hendrikKahl commented Feb 22, 2022 •
edited
Loading

Things to do:

  • replace deprecated fields - ref
  • update dependencies argo to 3.2.8
  • update helm chart with install manifests - ref
  • check, if we have to annotate ingress - ref
  • check, if we have to change the auth-mode
  • do lots and lots of testing

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 24, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 24, 2022
@hendrikKahl hendrikKahl marked this pull request as ready for review March 1, 2022 11:34
@hendrikKahl hendrikKahl requested a review from a team as a code owner March 1, 2022 11:34
@hendrikKahl
Copy link
Contributor

hendrikKahl commented Mar 3, 2022 •
edited
Loading

Summary of additionally included changes:

  • notable upgrades of go dependencies:
    • argo v3.28
    • k8s.io/api (and related packages) v0.21.5
    • k8s.io/client-go v0.21.5
    • sigs.k8s.io/controller-runtime v0.9.7
    • k8s.io/kube-openapi v0.0.0-20210305001622-591a79e4bda7
  • update of the helm chart deploying argo
    • renamed argo-ui to argo-server following the communities naming of argo components
    • argo CRD's are deployed in apiextensions.k8s.io/v1 instead of beta version
    • argo workflow-controller is deployed with a restrictive security context based on argo's release manifests
    • switch default image location of argo components from dockerhub to quay

dguendisch
dguendisch commented Mar 3, 2022
View reviewed changes
Copy link
Member Author

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 3, 2022
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 7, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 7, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 7, 2022
@hendrikKahl hendrikKahl merged commit a9fb65f into master Mar 7, 2022
@hendrikKahl hendrikKahl deleted the argo-v3 branch March 7, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikKahl hendrikKahl hendrikKahl approved these changes

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dguendisch @gardener-robot @gardener-ci-robot @hendrikKahl @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3