Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for input git artifacts from on-prem gitlab with SSH auth with user is not named git #5147

Closed
chtcvl opened this issue Feb 19, 2021 · 3 comments
Labels

Comments

@chtcvl
Copy link
Contributor

chtcvl commented Feb 19, 2021

Summary

Using SSH repo url in input artifact git driver - expecting git SSH user to be parsed from git repo url. Instead hardcoded git user is passed: workflow/artifacts/git/git.go#L44

Diagnostics

What Kubernetes provider are you using?
k8sapi

What version of Argo Workflows are you running?
3.0.0-rc2

    - name: workload
      inputs:
        artifacts:
        - name: workload-script
          path: /src
          git:
            repo: gitolite@gitlab.example.com:projects/workflows.git
            revision: "tasks/workflow"
            sshPrivateKeySecret:
              name: gitlab-ro-ssh
              key: gitlab-ro-ssh
            insecureIgnoreHostKey: true

Workflow status message:

exit code 1: Error; ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain; ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

On gitlab host:

Feb 19 16:30:10 gitlab.example.com sshd[115757]: Invalid user git from 10.24.0.246 port 51618
Feb 19 16:30:10 gitlab.example.com sshd[115757]: input_userauth_request: invalid user git [preauth]
Feb 19 16:30:10 gitlab.example.com sshd[115761]: Invalid user git from 10.24.0.247 port 52534
Feb 19 16:30:10 gitlab.example.com sshd[115761]: input_userauth_request: invalid user git [preauth]

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@simster7
Copy link
Member

Hmm, we use go-git(https://github.com/go-git/go-git) for all of our git operations. Are you able to clone your repo using git on the command line or is it just an issue when using Argo?

@chtcvl
Copy link
Contributor Author

chtcvl commented Feb 22, 2021

The issue is only when using Argo, since gitlab expects gitolite user and receives git user. Git clone works with the same key just fine when username is picked from url.

@stale
Copy link

stale bot commented Apr 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 24, 2021
@stale stale bot closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants