Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse username from git url when using SSH key auth #5156

Merged
merged 4 commits into from
Apr 6, 2021
Merged

fix: parse username from git url when using SSH key auth #5156

merged 4 commits into from
Apr 6, 2021

Conversation

chtcvl
Copy link
Contributor

@chtcvl chtcvl commented Feb 22, 2021

Checklist:

#5147

simster7
simster7 suggested changes Feb 22, 2021
View reviewed changes
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
@simster7 simster7 self-assigned this Feb 22, 2021
@chtcvl chtcvl force-pushed the ssh-user-from-git-url branch from ade3781 to ceb5084 Compare February 22, 2021 18:45
simster7
simster7 suggested changes Feb 22, 2021
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@chtcvl chtcvl force-pushed the ssh-user-from-git-url branch from ceb5084 to 4b842f9 Compare February 22, 2021 19:28
@simster7 simster7 marked this pull request as ready for review February 22, 2021 21:15
@simster7
Copy link
Member

You'll need to merge with master please

@chtcvl chtcvl requested a review from simster7 February 25, 2021 11:48
simster7
simster7 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @alexec Could I also ask you to take a look at this please? Two sets of eyes are better than one

alexec
alexec requested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@simster7 simster7 removed their assignment Mar 23, 2021
@simster7
Copy link
Member

@chtcvl Bump! Any interest in continuing this PR?

@chtcvl
Copy link
Contributor Author

chtcvl commented Mar 30, 2021

@chtcvl Bump! Any interest in continuing this PR?

yes, will address the requested changes shortly

chtcvl added 2 commits March 31, 2021 19:53
@chtcvl
fix: parse username from git url when using SSH key auth
e52e0e5 
Signed-off-by: vladimir.ivanov <vladimir.ivanov@grasshopperasia.com>
@chtcvl
Codegen
f10526c 
Signed-off-by: vladimir.ivanov <vladimir.ivanov@grasshopperasia.com>
@chtcvl chtcvl force-pushed the ssh-user-from-git-url branch from 5dba989 to f10526c Compare March 31, 2021 11:58
@chtcvl
Tests
0017635 
Signed-off-by: vladimir.ivanov <vladimir.ivanov@grasshopperasia.com>
@chtcvl chtcvl force-pushed the ssh-user-from-git-url branch from 825d275 to 0017635 Compare April 1, 2021 05:28
@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #5156 (0b72bef) into master (20f0047) will increase coverage by 0.00%.
The diff coverage is 47.36%.

❗ Current head 0b72bef differs from pull request most recent head ff14046. Consider uploading reports for the commit ff14046 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5156   +/-   ##
=======================================
  Coverage   47.04%   47.05%           
=======================================
  Files         240      240           
  Lines       15012    15007    -5     
=======================================
- Hits         7063     7062    -1     
+ Misses       7051     7045    -6     
- Partials      898      900    +2
Impacted Files Coverage Δ
cmd/argo/commands/node.go 0.00% <0.00%> (ø)
cmd/argo/commands/server.go 34.51% <0.00%> (ø)
persist/sqldb/workflow_archive.go 0.00% <0.00%> (ø)
workflow/common/common.go 100.00% <ø> (ø)
workflow/artifacts/git/git.go 40.21% <85.71%> (+3.43%) ⬆️
workflow/controller/workflowpod.go 71.99% <100.00%> (+0.12%) ⬆️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (-0.67%) ⬇️
workflow/controller/operator.go 70.69% <0.00%> (-0.28%) ⬇️
pkg/apiclient/http1/event-watch-client.go 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f0047...ff14046. Read the comment docs.

@chtcvl chtcvl requested a review from alexec April 1, 2021 05:59
alexec
alexec requested changes Apr 1, 2021
View reviewed changes
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
@chtcvl
Remove bool output
ff14046 
Signed-off-by: vladimir.ivanov <vladimir.ivanov@grasshopperasia.com>
@alexec alexec merged commit 9b6c8b4 into argoproj:master Apr 6, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
Closed
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
@chtcvl @simster7
fix: parse username from git url when using SSH key auth (#5156)
f6c47e4
@alexec alexec mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chtcvl @simster7 @alexec