You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue contains several minor issues related to CronWorkflow:
AFIAK we don't support the second-level CronWorkflow schedule. Second-level CronWorkflow will be rejected when submitting. But the crontab translator seems to have no problem with it. This is an inconsistent user experience:
Furthermore, for an existing & valid CronWorkflow, the user can actually update it to a second-level CronWorkflow, and the schedule doesn't seem to work (Next schedule time says "xx seconds ago").
We should have consistent UX for this.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered:
Fix UpdateCronWorkflow (server/cronworkflow/cron_workflow_server.go) to invoke validate.ValidateCronWorkflow (like CreateCronWorkflow` does on line 35)
Remove Next Scheduled Time (ui/src/app/cron-workflows/components/cron-workflow-status-viewer.tsx#L27-35). I think it is better to remove this feature than it to be buggy because it is based on wrong information.
The UI validator resides in <ScheduleValidator/> (ui/src/app/cron-workflows/components/schedule-validator.tsx). However, this will always only be roughly correct - and we cannot predict when it might be wrong. Instead, we should add an <InfoIcon /> to let users know that seconds are not supported.
Summary
This issue contains several minor issues related to CronWorkflow:
AFIAK we don't support the second-level CronWorkflow schedule. Second-level CronWorkflow will be rejected when submitting. But the crontab translator seems to have no problem with it. This is an inconsistent user experience:
Furthermore, for an existing & valid CronWorkflow, the user can actually update it to a second-level CronWorkflow, and the schedule doesn't seem to work (Next schedule time says "xx seconds ago").
We should have consistent UX for this.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: