Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken manifests #8188

Closed
3 tasks done
allemp opened this issue Mar 18, 2022 · 3 comments · Fixed by #8191
Closed
3 tasks done

Broken manifests #8188

allemp opened this issue Mar 18, 2022 · 3 comments · Fixed by #8191

Comments

@allemp
Copy link

allemp commented Mar 18, 2022

Checklist

  • Double-checked my configuration.
  • Tested using the latest version.
  • Used the Emissary executor.

Summary

What happened/what you expected to happen?

I want to run hello-world and expect it to successfully complete

Instead when describing the pod I get "failed to resolve reference "quay.io/argoproj/argoexec:untagged"

What version are you running?

I use the latest cluster-install manifests rolled out by argo-cd

This bug does not occur if I pin version to before the following commit 2b5e4a1d2df7877d9b7b7fbedd7136a125a39c8d

It would seem that the above commit broke the manifests.

Diagnostics

Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: hello-world-
  labels:
    workflows.argoproj.io/archive-strategy: "false"
  annotations:
    workflows.argoproj.io/description: |
      This is a simple hello world example.
      You can also run it in Python: https://couler-proj.github.io/couler/examples/#hello-world
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["hello world"]

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@allemp
Copy link
Author

allemp commented Mar 18, 2022

@alexec Do you know more about the intent behind the manifest change? Was the idea to pin image version to v3.3.0 instead of latest and it's a typo?

@terrytangyuan
Copy link
Member

terrytangyuan commented Mar 18, 2022

argo.GetVersion().Version might give us unexpected tag. cc @alexec

@alexec alexec self-assigned this Mar 18, 2022
@alexec
Copy link
Contributor

alexec commented Mar 18, 2022

Fixing.

alexec added a commit to alexec/argo-workflows that referenced this issue Mar 18, 2022
…j#8188

Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this issue Mar 18, 2022
…8191)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this issue Mar 23, 2022
…j#8188 (argoproj#8191)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this issue Apr 18, 2022
…8191)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants