Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to clone repo with ssh git submodule #8377

Closed
tcolgate opened this issue Apr 12, 2022 · 4 comments · Fixed by #8381
Closed

Unable to clone repo with ssh git submodule #8377

tcolgate opened this issue Apr 12, 2022 · 4 comments · Fixed by #8381
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/bug

Comments

@tcolgate
Copy link
Contributor

Running version v3.3.1 with 1d373c4 (which resolved #7469) cherry-picked into the executor

Workflows using git submodules fail to run. The init containers executor fails with ((I've redacted the org and repo names here)...

time="2022-04-12T07:30:28.713Z" level=info msg="Start loading input artifacts..."
time="2022-04-12T07:30:28.713Z" level=info msg="Downloading artifact: code"
time="2022-04-12T07:30:34.414Z" level=error msg="executor error: artifact code failed to load: pkt-line 1: invalid hash text: encoding/hex: invalid byte: U+0052 'R' (ERR \n  myorg/myrepo.git/myorg/mysubmodrepo is not a valid repository name\n  Visit https://support.github.com/ for help)"
time="2022-04-12T07:30:34.415Z" level=info msg="Alloc=216057 TotalAlloc=1090599 Sys=271515 NumGC=21 Goroutines=3"
time="2022-04-12T07:30:34.415Z" level=fatal msg="artifact code failed to load: pkt-line 1: invalid hash text: encoding/hex: invalid byte: U+0052 'R' (ERR \n  myorg/myrepo.git/myorg/mysubmodrepo is not a valid repository name\n  Visit https://support.github.com/ for help)"
@tcolgate
Copy link
Contributor Author

The .gitmodules for the impacted repositories are all of the form...

[submodule "dirname"]
        path = dirname
        url = git@github.com:myorg/myrepo.git
        branch = master

I think I've found the problem and will raise an issue in the go-git fork repo.

@tcolgate
Copy link
Contributor Author

argoproj-labs/go-git#3

@alexec alexec added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Apr 12, 2022
@alexec
Copy link
Contributor

alexec commented Apr 12, 2022

I've merged your fix and released it. Could you raise a PR to update this repo?

@tcolgate
Copy link
Contributor Author

@alexec done, thanks

alexec pushed a commit that referenced this issue Apr 13, 2022
Upgrades argoproj-labs/go-git fork to v5.4.4

Signed-off-by: Tristan Colgate <tcolgate@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this issue Apr 18, 2022
Upgrades argoproj-labs/go-git fork to v5.4.4

Signed-off-by: Tristan Colgate <tcolgate@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants