Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifact_server.go return error details on 401, should not #8382

Closed
alexec opened this issue Apr 12, 2022 · 0 comments · Fixed by #8383
Closed

artifact_server.go return error details on 401, should not #8382

alexec opened this issue Apr 12, 2022 · 0 comments · Fixed by #8383
Labels
area/sso-rbac good first issue Good for newcomers type/feature Feature request type/security Security related

Comments

@alexec
Copy link
Contributor

alexec commented Apr 12, 2022 

func (a *ArtifactServer) unauthorizedError(err error, w http.ResponseWriter) {
	w.WriteHeader(401)
	_, _ = w.Write([]byte(err.Error()))
}

Do not return the error.
@alexec alexec added type/feature Feature request type/security Security related good first issue Good for newcomers area/sso-rbac labels Apr 12, 2022
rohankmr414 added a commit to rohankmr414/argo-workflows that referenced this issue Apr 12, 2022
@rohankmr414
fix: removed error from artifact server 401 response. Fixes argoproj#…
561b0c7 
…8382

Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
@rohankmr414 rohankmr414 mentioned this issue Apr 12, 2022
Merged
alexec pushed a commit that referenced this issue Apr 12, 2022
@rohankmr414
fix: removed error from artifact server 401 response. Fixes #8382 (#8383
95323f8 
)

Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
Closed
85 tasks
sarabala1979 pushed a commit that referenced this issue Apr 18, 2022
@rohankmr414 @sarabala1979
fix: removed error from artifact server 401 response. Fixes #8382 (#8383
a327edd 
)

Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/sso-rbac good first issue Good for newcomers type/feature Feature request type/security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed error from artifact server 401 response. Fixes #8382 rohankmr414/argo-workflows
1 participant
@alexec