-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait container is terminated with wrong command #8687
Labels
Comments
alexec
added a commit
to alexec/argo-workflows
that referenced
this issue
Jun 3, 2022
Signed-off-by: Alex Collins <alex_collins@intuit.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions. |
terrytangyuan
pushed a commit
that referenced
this issue
Jun 13, 2022
sarabala1979
pushed a commit
that referenced
this issue
Aug 8, 2022
* fix: Correct kill command. Fixes #8687 Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix: ok Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix: ok Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
added a commit
that referenced
this issue
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In v3.4 we still try to terminate using
/bin/sh
but we need to introduceargoexec kill
instead.https://github.com/argoproj-labs/argo-dataflow/blob/8fbb255c01e744b6331faa269c96d8558b71e15a/kill/kill.go#L21
This will work for all cases now.
signalContainers
will exit on the first error runningSignalContainer
. It should instead continue or error, otherwisekillContainers
will never be invoked.The text was updated successfully, but these errors were encountered: