Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait container does not handle SIGTERM correctly #8699

Closed
alexec opened this issue May 11, 2022 · 3 comments
Closed

Wait container does not handle SIGTERM correctly #8699

alexec opened this issue May 11, 2022 · 3 comments
Labels
area/executor type/bug

Comments

@alexec
Copy link
Contributor

alexec commented May 11, 2022

The wait container should trap SIGTERM and gracefully shutdown, capturing artifacts.

However, if it recieves SIGTERM while capture artifacts, it will just exit.
alexec added a commit that referenced this issue May 11, 2022
@alexec
fix: lift up sig term. Fixes #8699
68a1b3c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue May 11, 2022
Closed
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jun 12, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this as completed Jul 10, 2022
@agilgur5
Copy link
Contributor

I believe this was fixed by #8908 or related PR

@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/executor type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Executor signal handling argoproj/argo-workflows
2 participants
@alexec @agilgur5