-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TTL to garbage collect old workflows #911
Comments
Thanks for pointing this issue. Similar to the ability to do a cascaded deletion via owner references, this will actually save a lot of unnecessary work in the workflow-controller if there is an upcoming mechanism to GC old workflows. |
Looking at the proposal a bit closer, it's going to be a long while before the TTL support CRDs (if ever). It'll be better to support this earlier in our types/controller, and remove the logic if & when the TTL controller supports custom resources. |
…oj#897 (argoproj#911) * feat(calendar): Support catchup on calendar eventsource * codegen * updated * Update event_persist.go * Update start.go * Update start.go * Added test * updated * Update event_persist_test.go * updated * updated * updated * addressed comments * Update start.go * updated * Reverted comment event * Update event_persist.go * Update event_persist.go * Fixed codegen and added maxCatchupDuration * Update calendar.yaml * Update start.go * Refactored Spec * updated * missed changes * Addressed Derek Comments * Update start.go * Update calendar.yaml * Update calendar.yaml * Update start.go
FEATURE REQUEST
A general problem in K8s is that batch jobs can accumulate overwhelming the master.
Kubeflow has experienced this with Argo workflows (as well as other resources kubeflow/testing#87).
There is a proposal in K8s to solve this by adding a TTL field to K8s jobs and implementing a TTL controller that could eventually be used with other resources.
kubernetes/kubernetes#64470
Design doc: https://goo.gl/YxtxTi.
I think Argo workflows should have a similar field and eventually support garbage collecting old workflows using the TTL controller.
The text was updated successfully, but these errors were encountered: