Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installer/uninstaller in favor of kubectl apply #928

Closed
jessesuen opened this issue Aug 1, 2018 · 2 comments
Closed

Remove installer/uninstaller in favor of kubectl apply #928

jessesuen opened this issue Aug 1, 2018 · 2 comments
Milestone

Comments

@jessesuen
Copy link
Member

jessesuen commented Aug 1, 2018

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

What happened:

The argo installer/uninstaller is not totally useful for the following reasons:

  • we will never accommodate everyone's desired installations. For example, customizing argo to have resource quotas is not possible via instalelr.
  • the installer does not benefit from kubectl apply semantics since it uses REST update instead of patch.
  • the uninstaller is too easy to shoot yourself in the foot by blowing away the CRD (and all workflows in the cluster).

This proposal is to remove the argo install and argo uninstall commands completely, and direct users to running kubectl apply to install argo instead.

@andreimc
Copy link
Contributor

andreimc commented Aug 3, 2018

@jessesuen I have written some helm charts for this that kinda provide a very easy way to configure and install argo. I am happy to adapt that for a more generic way.

jessesuen added a commit to jessesuen/argo-workflows that referenced this issue Aug 14, 2018
…rgument (issue argoproj#928)

Remove redundant/unused downward API metadata
@jessesuen
Copy link
Member Author

Thanks for offering @andreimc, looks like we are just now getting some help on the Argo Helm front (See: argoproj/argo-helm#14). Feel free to chime in there if you have any suggestions for improvements.

As for this issue, argo install and argo uninstall have now been removed so closing out this bug.

icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants