Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does P/R/C reporting on argo list -o wide still work? #9281

Closed
withnale opened this issue Aug 3, 2022 · 5 comments · Fixed by #9874
Closed

Does P/R/C reporting on argo list -o wide still work? #9281

withnale opened this issue Aug 3, 2022 · 5 comments · Fixed by #9874
Assignees
Labels

Comments

@withnale
Copy link

withnale commented Aug 3, 2022

Whenever I try running any of our workflows and I used

argo list -o wide  -A

NAMESPACE   NAME                                                         STATUS      AGE   DURATION   PRIORITY   P/R/C   PARAMETERS
dev         dev-abc-defghij-default-1659528000                           Running     4m    4m         0          0/0/0
dev         stable-another-job-def-g64cn                                 Succeeded   11d   7h         0          0/0/0

I've tried this with our job definitions and I've also tried this out of the box some of the workflows in argo-workflows/examples and I've yet to see a case where it works.

Summary

What happened/what you expected to happen?

The P/R/C column is populated based on the number of pending/running/completed steps of the workflow.

What version are you running?

We're running v3.2.9 but I've also tried it with v3.3.7

@alexec alexec added the area/cli The `argo` CLI label Sep 5, 2022
@alexec
Copy link
Contributor

alexec commented Sep 5, 2022

This happen because of this line of code:

It should be easy to add an option for wide.

@alexec alexec added good first issue Good for newcomers and removed triage labels Sep 5, 2022
@aditya-shrivastava
Copy link
Contributor

Hi @alexec, I am new to open source and would like to try and work on this issue.
Can you assign it to me?

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Oct 1, 2022
@aditya-shrivastava
Copy link
Contributor

Update on the issue: I have been learning Go and Kubernetes and reviewing the documentation to better understand the project.

@stale stale bot removed the problem/stale This has not had a response in some time label Oct 1, 2022
@aditya-shrivastava
Copy link
Contributor

aditya-shrivastava commented Oct 18, 2022

Hi @alexec, I have made the following changes:
bug-fIx

After running make cli I was able to submit an example workflow to get the expected P/R/C results:
submit-workflow
prc-working

Log of the example workflow:
steps-logs

Kindly let me know if this fixes the issue or if I need to make more changes.
Also, I would highly appreciate it if you could tell me what unit tests I should add for the above changes before making a pull request. 😃

aditya-shrivastava added a commit to aditya-shrivastava/argo-workflows that referenced this issue Oct 21, 2022
Signed-off-by: aditya-shrivastava <aditya.shrivastava251@gmail.com>
aditya-shrivastava added a commit to aditya-shrivastava/argo-workflows that referenced this issue Oct 21, 2022
Signed-off-by: aditya-shrivastava <aditya.shrivastava251@gmail.com>
terrytangyuan pushed a commit that referenced this issue Oct 21, 2022
Signed-off-by: aditya-shrivastava <aditya.shrivastava251@gmail.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
…roj#9874)

Signed-off-by: aditya-shrivastava <aditya.shrivastava251@gmail.com>
Signed-off-by: juchao <juchao@coscene.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants