Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when S3 secret has trailing newline #981

Closed
jessesuen opened this issue Sep 4, 2018 · 0 comments
Closed

Regression when S3 secret has trailing newline #981

jessesuen opened this issue Sep 4, 2018 · 0 comments

Comments

@jessesuen
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?: BUG REPORT

What happened:

Before v2.2.0, we used to trim whitespace from S3 access keys and secret keys. Somehow this got lost with the refactoring to use argoproj/pkg/s3. If there is a trailing newline, S3 operations fail with:

Get https://storage.googleapis.com/<BUCKETNAMEREDACTED>/?location=: net/http: invalid header field value "AWS <ACCESSKEYREDACTED>\n:XXXXXXXXXXXX" for key Authorization

Anything else we need to know?:

Workaround is to trim the trailing newline in the secret

Environment:

  • Argo version: v2.2.0
icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this issue Jan 5, 2022
@scottweitzner @VaibhavPage
Fix/eventsource resource return entire event object (argoproj#981)
6ee3328 
* fix(eventsource/resource): return entire event object instead of just event.obj

Signed-off-by: Scott Weitzner <scottweitzner@gmail.com>

* feat(eventsource/resource): add new filed to pass in old object to ResourceEventData

Signed-off-by: Scott Weitzner <scott.weitzner@blackrock.com>

* feat(eventsource/resource): for event body refer to event.Obj instead of just event

Signed-off-by: Scott Weitzner <scott.weitzner@blackrock.com>

Co-authored-by: Vaibhav <vaibhav.page@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessesuen