Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added logs related to executing commands in the container #10530

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

sxllwx
Copy link
Contributor

@sxllwx sxllwx commented Feb 14, 2023

Signed-off-by: scott scottwangsxll@gmail.com

Fixes:

In the process of troubleshooting #10490, we found that our wait received more than one sigterm.

However, when wf-controller sends sigterm for the second time (actually through argoexec kill), it may cause container-crash (signal processing is asynchronous), and we need this part of the log to support our troubleshooting.

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@sxllwx sxllwx marked this pull request as ready for review February 14, 2023 02:54
Copy link
Contributor

@tooptoop4 tooptoop4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Debug level instead of Info level (already the amount of logs are expensive). Could the command contain sensitive text (ie result of secret/pw)?

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if #10523 works?

workflow/signal/signal.go Outdated Show resolved Hide resolved
workflow/signal/signal.go Outdated Show resolved Hide resolved
Signed-off-by: scott <scottwangsxll@gmail.com>
@alexec alexec merged commit 781675d into argoproj:master Mar 5, 2023
alexec pushed a commit that referenced this pull request Mar 5, 2023
terrytangyuan pushed a commit that referenced this pull request Mar 29, 2023
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants