-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added logs related to executing commands in the container #10530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Debug level instead of Info level (already the amount of logs are expensive). Could the command contain sensitive text (ie result of secret/pw)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this if #10523 works?
Signed-off-by: scott <scottwangsxll@gmail.com>
Signed-off-by: scott <scottwangsxll@gmail.com>
Signed-off-by: scott <scottwangsxll@gmail.com>
…roj#10530) Signed-off-by: scott <scottwangsxll@gmail.com>
Signed-off-by: scott scottwangsxll@gmail.com
Fixes:
In the process of troubleshooting #10490, we found that our
wait
received more than one sigterm.However, when wf-controller sends sigterm for the second time (actually through argoexec kill), it may cause container-crash (signal processing is asynchronous), and we need this part of the log to support our troubleshooting.
Please do not open a pull request until you have checked ALL of these:
make pre-commit -B
to fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.