Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change log severity when artifact is not found #10561

Conversation

CiprianAnton
Copy link
Contributor

@CiprianAnton CiprianAnton commented Feb 21, 2023

Artifacts can be optional, logging a missing output artifact as error has too high severity, this will be highly visible in the logs requiring attention. Change severity to warning, similar with what is being logged in wait container: https://github.com/argoproj/argo-workflows/blob/master/workflow/executor/executor.go#L316

Fixes #change log severity when artifact is not found

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Ciprian Anton <ciprian.anton@ni.com>
@CiprianAnton CiprianAnton force-pushed the users/canton/change-log-severity-for-optional-artifacts branch from c27cbd5 to 41593e4 Compare February 21, 2023 15:53
@CiprianAnton CiprianAnton changed the title Change log severity when artifact is not found fix: change log severity when artifact is not found Feb 21, 2023
@CiprianAnton CiprianAnton reopened this Feb 21, 2023
@CiprianAnton CiprianAnton marked this pull request as ready for review February 22, 2023 08:39
@alexec alexec merged commit 77da050 into argoproj:master Feb 24, 2023
terrytangyuan pushed a commit that referenced this pull request Mar 29, 2023
Signed-off-by: Ciprian Anton <ciprian.anton@ni.com>
@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants