fix: PVC in wf.status should be reset when retrying workflow #10685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
jessesuen
reviewed
Mar 16, 2023
@jessesuen I thought about that as well. This is the simplest fix without introducing additional API calls and complicating controller code. I cannot think of other use cases other than workflow retry. Another consideration is that when an engineer accidentally deletes the PVC, we want their workflows to fail and be aware of mistakes instead of silently recreating PVC. It's intuitive to recreate the PVC when retrying a workflow. |
alexec
approved these changes
Mar 17, 2023
33 tasks
terrytangyuan
added a commit
that referenced
this pull request
Mar 29, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…j#10685) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a retried workflow would fail with the error
persistentvolumeclaim xxx not foundif the PVC is deleted previously (e.g. volumeClaimGC strategy is set toOnWorkflowCompletion). We can fix this by resetting the PVC in workflow status so that the operator could recreate the PVC.