Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Comment out a flaky test in TestTemplateLevelHooksStepSuccessVersion #11384

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

terrytangyuan
Copy link
Member

  ✔ lifecycle-hook-tmpl-level-dtcwf   Workflow  43s     
 └ ✔ step-1                          Pod       7s      
 └ ✔ lifecycle-hook-tmpl-level-dtcwf Steps     43s     
 └ ✔ [0]                             StepGroup 24s     
 └ ✔ step-1.hooks.running            Pod       4s      
 └ ✔ step-1.hooks.succeed            Pod       12s     
 └ ✔ [1]                             StepGroup 19s     
 └ ✔ step-2                          Pod       4s      
 └ ✔ step-2.hooks.succeed            Pod       5s      
 
     suite.go:87: test panicked: runtime error: invalid memory address or nil pointer dereference
        goroutine 670 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.20.5/x64/src/runtime/debug/stack.go:24 +0x65
        github.com/stretchr/testify/suite.failOnPanic(0xc00033fd40, {0x1b90420, 0x2f63060})
        	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:87 +0x3b
        github.com/stretchr/testify/suite.Run.func1.1()
        	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:183 +0x252
        panic({0x1b90420, 0x2f63060})
        	/opt/hostedtoolcache/go/1.20.5/x64/src/runtime/panic.go:884 +0x213
        github.com/argoproj/argo-workflows/v3/test/e2e.(*HooksSuite).TestTemplateLevelHooksStepSuccessVersion.func9(0x20b0240?, 0xc000014018?, 0xc00066cf40?)
        	/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:172 +0x19
        github.com/argoproj/argo-workflows/v3/test/e2e/fixtures.(*Then).ExpectWorkflowNode.func1(0x20b0240?, 0xc000764da0, 0xc00066d4b0?)
        	/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:110 +0x4c9
        github.com/argoproj/argo-workflows/v3/test/e2e/fixtures.(*Then).expectWorkflow(0xc00066d580, {0xc0009b1c60, 0x1f}, 0xc00066d520)
        	/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:68 +0x31f
        github.com/argoproj/argo-workflows/v3/test/e2e/fixtures.(*Then).ExpectWorkflowNode(0xc0000f1580?, 0xc0000f1570?, 0x1?)
        	/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:85 +0x51
        github.com/argoproj/argo-workflows/v3/test/e2e.(*HooksSuite).TestTemplateLevelHooksStepSuccessVersion(0x0?)
        	/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:169 +0x325
        reflect.Value.call({0xc0007bb5c0?, 0xc00036e338?, 0xc12593a509740198?}, {0x1e0cee9, 0x4}, {0xc0006c5e70, 0x1, 0x18f648e?})
        	/opt/hostedtoolcache/go/1.20.5/x64/src/reflect/value.go:586 +0xb0b
        reflect.Value.Call({0xc0007bb5c0?, 0xc00036e338?, 0xc00030e000?}, {0xc0006c5e70?, 0x29cfa80?, 0x213ada0?})
        	/opt/hostedtoolcache/go/1.20.5/x64/src/reflect/value.go:370 +0xbc
        github.com/stretchr/testify/suite.Run.func1(0xc00033fd40)
        	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:197 +0x4b6
        testing.tRunner(0xc00033fd40, 0xc00055d320)
        	/opt/hostedtoolcache/go/1.20.5/x64/src/testing/testing.go:1576 +0x10b
        created by testing.(*T).Run
        	/opt/hostedtoolcache/go/1.20.5/x64/src/testing/testing.go:1629 +0x3ea

…rsion

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Jul 18, 2023
3 tasks
@terrytangyuan terrytangyuan enabled auto-merge (squash) July 18, 2023 16:52
@terrytangyuan terrytangyuan merged commit 15f118b into argoproj:master Jul 18, 2023
22 checks passed
@terrytangyuan terrytangyuan deleted the disable-flaky-test branch July 18, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants