fix: UI toolbar sticky #11444
Merged
fix: UI toolbar sticky #11444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ycow <skypnal12@gmail.com>
Signed-off-by: Ycow <skypnal12@gmail.com>
45 tasks
terrytangyuan
added a commit
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Ycow <skypnal12@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Ycow <skypnal12@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11442
Motivation
The
position:stickyin the workflows-toolbar is not working.Modifications
For a better UX, we changed the workflows-toolbar component from not being position sticky to being able to see the toolbar after scrolling.
Verification