Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose the Cron workflow workers as argument #11457

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat: Expose the Cron workflow workers as argument #11457

merged 3 commits into from
Jul 28, 2023

Conversation

sarabala1979
Copy link
Member

Fixes #TODO

Motivation

Modifications

Verification

@sarabala1979
feat: Expose the Cron workflow workers as argument
992b957 
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@sarabala1979 sarabala1979 marked this pull request as ready for review July 27, 2023 20:38
@sarabala1979 sarabala1979 merged commit be0bdf9 into argoproj:master Jul 28, 2023
@agilgur5
Copy link

Fixes #11454 (though as arg, not configmap option)

@agilgur5
Copy link

agilgur5 commented Jul 29, 2023 •
edited
Loading

We should add some docs for this new feature as well.
Also, I might be wrong, but I think some of the other flags are not documented either? Flags could be a good use case for docgen

@terrytangyuan terrytangyuan mentioned this pull request Aug 2, 2023
Closed
@agilgur5 agilgur5 added area/controller Controller issues, panics area/cron-workflows labels Aug 8, 2023
@agilgur5
Copy link

We should add some docs for this new feature as well.

Docs were added for this feature in #11731

@argoproj argoproj locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliev0 juliev0 juliev0 approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/controller Controller issues, panics area/cron-workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarabala1979 @agilgur5 @terrytangyuan @juliev0