-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): remove unneeded Yarn resolutions #11641
chore(deps): remove unneeded Yarn resolutions #11641
Conversation
- removing these has no impact on resolution, as can be seen in the `yarn.lock` - any bumps in these deps will produce either the same minor or same major version (most are same minor version) -- i.e. no breaking changes - remove resolutions for `@types/react`, `autolinker`, `fast-json-patch`, `lodash`, and `prismjs` Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dedf380
to
6abc93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember these resolutions were added to resolve security issues.
Per the first line of the PR, removing these has no impact on resolution. I imagine that those resolutions are either outdated or were used incorrectly to update a version in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge and see if Snyk check passes
It did 😉 . |
Motivation
yarn.lock
Related to #11630, which removes unused deps; this removes unneeded
resolutions
Modifications
remove resolutions for
@types/react
,autolinker
,fast-json-patch
,lodash
, andprismjs
did not touch
semver
orreact-toastify
semver
resolution currently forces all versions to the same as the resolution (including different majors, which can be seen in theyarn.lock
)thereact-toastify
resolution was needed for fix: upgradeargo-ui
components to latest #11585 and it is removed as part of build upgrades in build(ui): upgrade to Webpack v5 + upgrade loaders + plugins #11628Verification
Install succeeds, build passes.
Spot check on render.