Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: temporal workaround for flakiness of TestStopBehavior #11881

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

toyamagu-2021
Copy link
Member

@toyamagu-2021 toyamagu-2021 commented Sep 24, 2023

Signed-off-by: toyamagu2021@gmail.com toyamagu2021@gmail.com

Relates #11880
Partial fix for #10807

Motivation

  • Fix flaky test TestStopBehavior

Modifications

  • Ensure workflow-level hook is finished after template-level hook is finished.

Verification

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
@toyamagu-2021 toyamagu-2021 marked this pull request as ready for review September 24, 2023 09:25
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me based on the issue. Nice find again!

@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Sep 24, 2023
@agilgur5
Copy link
Member

PartiallyFixes #10807

Btw, I use the phrasing "partial fix for" so that GH doesn't close the respective issue

@terrytangyuan terrytangyuan merged commit 35e4b17 into argoproj:master Sep 24, 2023
26 checks passed
@toyamagu-2021 toyamagu-2021 deleted the partifaly-fix-10807 branch September 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants