Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove flaky assertion from hook e2e test #12007

Merged
merged 1 commit into from
Oct 15, 2023
Merged

ci: remove flaky assertion from hook e2e test #12007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/e2e/hooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,10 @@ spec:
}).ExpectWorkflowNode(func(status v1alpha1.NodeStatus) bool {
return strings.Contains(status.Name, "step-2.hooks.running")
}, func(t *testing.T, status *v1alpha1.NodeStatus, pod *apiv1.Pod) {
assert.Equal(t, v1alpha1.NodeSucceeded, status.Phase)
// TODO: Temporarily comment out this assertion since it's flaky:
// The running hook is occasionally not triggered. Possibly because the step finishes too quickly
// while the controller did not get a chance to trigger this hook.
//assert.Equal(t, v1alpha1.NodeSucceeded, status.Phase)
})
}

Expand Down