fix(deps): upgrade swagger-ui-react to latest 4.x.x
#12058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there are still some build issues to resolve in order to move to 5.x.x, but in the interim, can move to latest 4.x.x - in particular, this upgrade fixes an XSS CVE in a pinned dep of `swagger-ui-react`, `@braintree/santize-url`: https://security.snyk.io/vuln/SNYK-JS-BRAINTREESANITIZEURL-3330766 - see that it is pinned here, so we could not independently upgrade it without upgrading `swagger-ui-react` itself: https://github.com/argoproj/argo-workflows/blob/5c264c094104645a4c917a9a23615424d564d1e4/ui/yarn.lock#L7702 - note that it is _still_ pinned in latest 4.x.x of `swagger-ui-react`, but it is at least a newer patch version not susceptible to the CVE - this adds a lot of new deps, which I am not a fan of, seemingly because it moves to `@swagger` libraries for some behaviors - but on the bright side, the actual Swagger UI seems to lag / freeze less and work a little bit better now! Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
This was referenced Oct 21, 2023
7 tasks
terrytangyuan
approved these changes
Oct 21, 2023
sarabala1979
pushed a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
This was referenced Jan 17, 2024
agilgur5
changed the title
swagger-ui-react to latest 4.x.xswagger-ui-react to latest 4.x.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12036, where the last vulnerable UI dep was unable to be auto-fixed due to being pinned by
swagger-ui-reactMotivation
swagger-ui-react,@braintree/santize-url: https://security.snyk.io/vuln/SNYK-JS-BRAINTREESANITIZEURL-3330766swagger-ui-reactitself:argo-workflows/ui/yarn.lock
Line 7702 in 5c264c0
swagger-ui-react, but it is at least a newer patch version not susceptible to the CVEModifications
upgrade
swagger-ui-reactfrom 4.12.0 -> 4.19.1, latest of 4.x.x@swaggerlibraries for some behaviorsVerification
Tested the
/apidocsroute myself locally, see below screenshot:Future Work
I would still like to code-split out the
/apidocspage as a separate bundle, since it is rarely used yet has a lot of deps, and I believe includes the full Swagger file as well. That should help with issues like #11970ApiDocsandReportscomponents #12061