fix(ui): Cost Opt should only apply to live Workflows #12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- after the unification of the Archived + Live Workflow APIs and UIs in 82310dd, the `WorkflowsList`'s `CostOptimisationNudge` was not altered to account for the additional Archived Workflows - as such, it started showing up even for users with solid GC and archiving configurations - change the counting logic to skip archived workflows, which are explicitly excluded in the docs - using the Workflow Archive is one of the recommended options in fact - small grammar fix: comma splice in the `CostOptimisationNudge` message itself, where there is already a conjunction - small docs clarifications and grammar fixes: - consistently use "the" Workflow Archive, not "a" Workflow Archive - there is only one and the Workflow Archive page uses "the" - Workflow Archive is not an "or" with deleting Workflows, it would be an "and" - but it is optional, so split that into a second sentence with "you can" - "enable [...] and you can still view them" was confusing wording as it used a conjunction (on top of the incorrect conjunction above) instead of a preposition - change to "enable [...] to continue viewing" Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
`isArchivedWorkflow` should handle it same as `countsByCompleted` already does Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Nov 9, 2023
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12160
Motivation
WorkflowsList'sCostOptimisationNudgewas not altered to account for the additional Archived WorkflowsModifications
change the counting logic to skip archived workflows, which are explicitly excluded in the docs
small code fixes/optimizations:
isArchivedWorkflowfunc same as incountsByCompletedfuncsmall grammar fix: comma splice in the
CostOptimisationNudgemessage itself, where there is already a conjunctionsmall docs clarifications and grammar fixes:
Verification
Tested locally by reducing the count to 10. It correctly skips the 1 archived workflow I have in the list. Screenshot: