Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add functional tests for memoization without outputs #12215

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Nov 17, 2023

Fixes #12129 - see that issue for details.

Add a couple of tests which check memoization still happens without outputs.

Verification

These tests fail with c751e66 reverted.

Fixes argoproj#12129 - see that issue for details.

Add a couple of tests which check memoization still happens without outputs.

Signed-off-by: Alan Clucas <alan@clucas.org>
@terrytangyuan terrytangyuan changed the title chore: add functional tests for memoization without outputs test: add functional tests for memoization without outputs Nov 17, 2023
@terrytangyuan terrytangyuan merged commit b51320b into argoproj:master Nov 17, 2023
27 checks passed
@Joibel Joibel deleted the test-memoization-noout branch November 20, 2023 21:37
shuangkun pushed a commit to shuangkun/argo-workflows that referenced this pull request Nov 21, 2023
terrytangyuan pushed a commit that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for memoization without outputs did not catch regression
3 participants