fix: liveness check (healthz) type asserts to wrong type #12353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
This was referenced Dec 13, 2023
sarabala1979
pushed a commit
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
sarabala1979
pushed a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
sarabala1979
pushed a commit
that referenced
this pull request
Jan 13, 2024
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12326
Motivation
The liveness check was passing the WorkflowController's Workflow Informer to some code which assumes that the Informer holds types of
*Workflowbut in fact the Controller's informer holds types of*Unstructured. The effect was that the code would panic on the type assertion here.Modifications
Incorporate code which lists the Workflows from the Informer using
*Unstructuredtype.Verification
Both through a new unit test, plus through running the Controller and purposely blocking the reconciliation code so I could hit the healthz endpoint and cause the 500 error.
Beyond this PR