fix: Mark resource & data template report-outputs-completed: "true"

[shuangkun]

I run two example(use latest image):
https://github.com/argoproj/argo-workflows/blob/main/test/e2e/testdata/resource-templates/outputs.yaml
https://github.com/argoproj/argo-workflows/blob/main/test/e2e/testdata/data-transformation.yaml
I find the workflow succeed but the workflowtaskresult have two is not marked true.
The two is resource and data template. So I want to mark resource and data report-outputs-completed true.

tianshuangkun@B-QGHAMD6M-2124 myworkflow % argo list
NAME                        STATUS      AGE   DURATION   PRIORITY
data-transformation-ff287   Succeeded   2h    2h         0
outputs-fww7h               Succeeded   6h    6h         0
tianshuangkun@B-QGHAMD6M-2124 myworkflow % kubectl get workflowtaskresults -o yaml | grep workflows.argoproj.io/report-outputs-completed
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "false"
      workflows.argoproj.io/report-outputs-completed: "true"
      workflows.argoproj.io/report-outputs-completed: "false"
tianshuangkun@B-QGHAMD6M-2124 myworkflow %

Motivation

Modifications

Verification

[juliev0]

Great job catching this ahead of another Issue that found it! And resolving it as well.

[juliev0]

@Garett-MacGowan will you also review this one?

[Garett-MacGowan]

Once comments are resolved, LGTM.

[Garett-MacGowan]

Just to be clear, we were already initializing outputs (creating a task result) somewhere in order to get workflows.argoproj.io/report-outputs-completed: "false", right? Where was this happening? If its the wait container running in the main container, why does the defer not run? Do we actually need to initialize outputs here? Aren't we double initializing?

Edit: I should have looked deeper before commenting. This was a shower thought.

[Garett-MacGowan]

Just to be clear, we were already initializing outputs (creating a task result) somewhere in order to get workflows.argoproj.io/report-outputs-completed: "false", right? Where was this happening? If its the wait container running in the main container, why does the defer not run? Do we actually need to initialize outputs here? Aren't we double initializing?

Nevermind, ReportOutputs does an upsert, so its necessary to initialize here. LGTM

[juliev0]

Just to be clear, we were already initializing outputs (creating a task result) somewhere in order to get workflows.argoproj.io/report-outputs-completed: "false", right? Where was this happening? If its the wait container running in the main container, why does the defer not run? Do we actually need to initialize outputs here? Aren't we double initializing?

Edit: I should have looked deeper before commenting. This was a shower thought.

I can relate to the "shower thought" :)